Conversation
Voyagerroc-Lab
left a comment
Voyagerroc-Lab
left a comment
There was a problem hiding this comment.
Reviewed c353b03. The explicit is not None guard correctly distinguishes an omitted value from an empty string. The parent commit drops the empty argument; this change preserves it as "", and the CLI regression verifies that the resulting .env value is actually empty. Additional comparisons against the parent retained the existing output for None, "0", ordinary strings, strings containing spaces, and a whitespace-only value.
Validation on Windows / CPython 3.14.7: full suite 207 passed, 50 skipped; Ruff lint and formatting checks passed. The local run needed Git for Windows' printenv on PATH for the existing subprocess tests.
Review and validation performed with OpenAI Codex at the account owner's request.
2 participants
Preserve explicit empty strings in get_cli_string as "" while continuing to omit None. Previously, the generated command dropped the required value argument.
Add regression coverage that invokes the CLI and verifies the saved empty value.
Validation on Windows with Python 3.12: 207 passed, 50 skipped. Regression fails before the fix and passes afterward. Ruff checks and formatting passed.